famanson / spring-roll-demo

Demo site for Project Spring Roll
1 stars 0 forks source link

CORS support to fix the broken message submission #28

Closed famanson closed 10 years ago

famanson commented 10 years ago

@macduy please take a look and I'll merge

famanson commented 10 years ago

(also tested locally - you can check in ukspringroll@gmail.com's inbox)

macduy commented 10 years ago

Looks good to me. Please merge and push.

macduy commented 10 years ago

Btw, I don't understand much about the security implication of this. Just wanted to flag that up, don't think we'd run into anything.

famanson commented 10 years ago

Not much really, just that we can send ajax requests to another host. I've got checks on the other side to make sure that it does not do anything too funny (of course it is nowhere near a fully secured system now or in the first place)

Not like people will send their banking details to us