search

famanson / spring-roll-demo

Demo site for Project Spring Roll
1 stars 0 forks source link

Missing number of searches in search result #30

Closed famanson closed 10 years ago

famanson commented 10 years ago

missing-search-number

macduy commented 10 years ago

ugh, some terrible merge conflicts must have happened.. postCount has been removed.

macduy commented 10 years ago

@cuctacuctac, this would be a nice fix for you to do, would you be interested?

cuctacuctac commented 10 years ago

can do

cuctacuctac commented 10 years ago

fixed https://github.com/famanson/spring-roll-demo/commit/329505ef0f805e48be86fefd25c20d2f1676332d

macduy commented 10 years ago

Can you please try again? You don't need a new model variable.

cuctacuctac commented 10 years ago

righteo https://github.com/famanson/spring-roll-demo/commit/3866d80e6ca76e462fc29e720b845358727e2318

macduy commented 10 years ago

:+1: you can close this now

famanson commented 10 years ago

@cuctacuctac I'll close this manually but next time you can include "Fix #30" in your commit message, it will automatically close the issue (only a GitHub thing)

macduy commented 10 years ago

Awww, next time close it before @famanson robs you of the pleasure ;)

cuctacuctac commented 10 years ago

by commit message you mean the Description? or Summary? I'm talking GitHub for Mac here

macduy commented 10 years ago

Whichever is the first line.

Hai On 4 Jun 2014 23:25, "Nhung Tran" notifications@github.com wrote:

by commit message you mean the Description? or Summary? I'm talking GitHub for Mac here

— Reply to this email directly or view it on GitHub https://github.com/famanson/spring-roll-demo/issues/30#issuecomment-45160056 .

famanson commented 10 years ago

That'd be the summary. I'll often refer to it as the commit message fyi