search

famanson / spring-roll-demo

Demo site for Project Spring Roll
1 stars 0 forks source link

Add features #22: Logo clickable - reload page #31

Closed congpine closed 10 years ago

congpine commented 10 years ago

WIP: Mouse pointer not changing above the logo

macduy commented 10 years ago

I really want the pointy finger above the logo

famanson commented 10 years ago

Cursor thing can be fixed easily in styles.less, no? On 4 Jun 2014 22:32, "congpine" notifications@github.com wrote:

WIP: Mouse pointer not changing above the logo

You can merge this Pull Request by running

git pull https://github.com/famanson/spring-roll-demo logoClick

Or view, comment on, or merge it at:

https://github.com/famanson/spring-roll-demo/pull/31 Commit Summary

  • Add features #22: Logo clickable - reload page

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/famanson/spring-roll-demo/pull/31.

congpine commented 10 years ago

Done ! can you please review and merge.?

macduy commented 10 years ago

Looks good. @famanson suggestion would be another way of doing it, but what you did is fine.

macduy commented 10 years ago

Please merge.

famanson commented 10 years ago

Tbh I still prefer using cursor:pointer in styles.less. I don't really like having anchors that actually does not do anything, but just hanging around for the style

macduy commented 10 years ago

that's not strictly true. Anchors are actionable, it's not that uncommon to be using .

famanson commented 10 years ago

Cool. I'll take the expert's word for it :P On 5 Jun 2014 11:38, "Mac Duy Hai" notifications@github.com wrote:

that's not strictly true. Anchors are actionable, it's not that uncommon to be using .

— Reply to this email directly or view it on GitHub https://github.com/famanson/spring-roll-demo/pull/31#issuecomment-45204322 .