A message form potentially will be used in our feedback function

[famanson]

@macduy Take a look when you have time?

[cuctacuctac]

Some of my thoughts:

• Having a preview button would be nice, especially once Upload Photo is enable
• I was thinking whether it's worth to add a section for subgroups, e.g. for Sale, there would be a drop down for Electronics, Books... while for Rent it should definitely be Looking for housing or Looking for Tenants. Then we could colour code the posts according to their subgroups (either with background colour or font colour). It's similar to the automatic tagging system that someone mentioned in the forum but here you let people do the tagging themselves.
• Very minor point but I'm not a big fan of the current colours used in Compose. Could we have Discard in the same shade of red as the heading for each post, and have New Ad in the darkest green that is used for the logo (on the 3 sushi roll lookalikes) please?

[famanson]

@cuctacuctac seems like the wrong place for your comment here, Nhung :P

Anyhow, your first 2 points are in our backlog in the actual app, we just don't put them in the demo (especially the tagging system because I am sure that we'd have to refactor that big time when we move on to the real app)

@macduy can you please take a look at these colours suggestion please?

Very minor point but I'm not a big fan of the current colours used in Compose. Could we have Discard in the same shade of red as the heading for each post, and have New Ad in the darkest green that is used for the logo (on the 3 sushi roll lookalikes) please?

[macduy]

Mostly design:

• Get rid of the reds. Close should be grey so that it does not attract attention. Same for the bot thing. I know that the user needs to tick it but I don't find it desirable that we toot that in their face straight off the bat.
• I will turn the "Say hello" into a button, because otherwise it gets lost.

[macduy]

"Prove that you're human! (Bottom-left checkbox)" - we shouldn't be telling users where the checkbox is, point the tooltip at it instead.

[famanson]

Yeah was about to do it but I realised the tooltip code is in compose. Should we make it a public thing?

On 24 May 2014 17:21, Mac Duy Hai notifications@github.com wrote:

"Prove that you're human! (Bottom-left checkbox)" - we shouldn't be telling users where the checkbox is, point the tooltip at it instead.

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/pull/7#issuecomment-44092137 .

[famanson]

Get rid of the reds. Close should be grey so that it does not attract attention. Same for the bot thing. I know that the user needs to tick it but I don't find it desirable that we toot that in their face straight off the bat.

In the same place, a grey Send means it is disabled, would making Close grey as well be confusing?

[macduy]

Good point, I think the Close should just be a link, not a button.

[macduy]

Re tooltip: if it makes sense codewise, we should do it

[macduy]

Otherwise, I'm happy with the changes, feel free to merge/address comments in any order ;)

[famanson]

ok I'll see what I can do about Close before merging. Then we can do the tooltip refactoring after the merge

[famanson]

@macduy Alright, I made some of the styling changes. Can you take another pass then I'll merge

[macduy]

Mmm, nice! Alright, let's merge this. Honour's yours, @famanson

[famanson]

Merged, will :ship: to our demo site when I get all the php crap set up on my server :P

[macduy]

btw did you remove the "Show gridlines" checkbox in the public demo?

[famanson]

lol it is there. I'll disable it in prod

[macduy]

@mrbateuk will take a look at this and provide further design feedback