New post viewing

[macduy]

@famanson, @cuctacuctac Still very rough around the edges, just wanted to know your opinion and where should we take this.

[famanson]

I like the idea. A couple of things off the top of my head:

• The theatre needs to be bigger + image resize properly (I'm sure you are working on it)
• It needs to be clearer what to do. Wasn't the most obvious thing to do for me at first to click for "flipping" the page to see a photo

On 24 May 2014 16:43, Mac Duy Hai notifications@github.com wrote:

@famanson https://github.com/famanson, @cuctacuctachttps://github.com/cuctacuctacStill very rough around the edges, just wanted to know your opinion and

where should we take this.

You can merge this Pull Request by running

git pull https://github.com/famanson/spring-roll-demo post-theatre

Or view, comment on, or merge it at:

https://github.com/famanson/spring-roll-demo/pull/8 Commit Summary

• Merge branch 'master' into post-theatre
• Merge branch 'master' into post-theatre
• Slide-deck style post presentation. WIP

File Changes

• M index.htmlhttps://github.com/famanson/spring-roll-demo/pull/8/files#diff-0(23)
• M js/controllers.jshttps://github.com/famanson/spring-roll-demo/pull/8/files#diff-1(51)
• M js/native.jshttps://github.com/famanson/spring-roll-demo/pull/8/files#diff-2(4)
• M styles/styles.lesshttps://github.com/famanson/spring-roll-demo/pull/8/files#diff-3(67)

Patch Links:

• https://github.com/famanson/spring-roll-demo/pull/8.patch
• https://github.com/famanson/spring-roll-demo/pull/8.diff

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/pull/8 .

[macduy]

Thanks, yeah this is very WIP. I think the theatre will definitely need to resize to accommodate for the picture (though starting size will be fixed - we can tweak that afterwards)

[famanson]

Feature request: I want an indicator on the image deck like the featured posts on: http://www.goal.com/en-gb/. They have a dot indicator of which image we are looking at

[macduy]

Yep, it's in the works.

Hai On 25 May 2014 22:15, "famanson" notifications@github.com wrote:

Feature request: I want an indicator on the image deck like the featured posts on: http://www.goal.com/en-gb/. They have a dot indicator of which image we are looking at

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/pull/8#issuecomment-44145697 .

[macduy]

Please note that this branch is now quite buggy. WIP ;)

[famanson]

@macduy what is not working on this branch atm? I'd say we fix it quickly and deploy to master and work more on the rest later. I want to get some people's feedback on the image deck

[macduy]

I want to do these things first:

• Hover effects (this indicates to the user there are photos)
• Prevent animations when opening the post (as it reuses the same DOM elements) )
• Clean up the code

[famanson]

Hover effects (this indicates to the user there are photos)

Isn't the camera icon enough to indicate that?

[macduy]

Ah what I meant is: when you open a post, the images take a tiny amount of space on the right. When you hover the post, they'll stick out a bit more, to lure you into clicking them. Not sure how exactly it will look yet.

Hai On 28 May 2014 21:59, "famanson" notifications@github.com wrote:

Hover effects (this indicates to the user there are photos)

Isn't the camera icon enough to indicate that?

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/pull/8#issuecomment-44463731 .

[famanson]

@macduy right, gotcha. I like that idea. We could make it look a bit like an envelope, when you hover over the right edge, there would be either a small thumbnail or a small icon popping out? Does that even make sense?

[macduy]

Alright, this is ready to go! Please let me know if I can merge.

[famanson]

@macduy added an autofocus function that got lost during an earlier merge (for the messages). Other than that all good to go

[famanson]

awesome, will deploy

[macduy]

Let's create a tag!