chore: change conditional to support manjaro - [merged] #11

Closed famedly-bot closed 1 year ago

In GitLab by @Ratzupaltuff on Feb 3, 2021, 17:58

Merges ratzupaltuff/manjaro-intallation -> main

not only support archlinux but manjaro(arm) too

In GitLab by @jcgruenhage on Feb 4, 2021, 01:10

Commented on roles/yggdrasil/tasks/install.yml line 12

Two small nitpicks:

ansible exposes it's facts as vars with the ansible_ prefix, so you can use ansible_os_family here instead
it'd make sense to change this not only for arch, but use ansible_os_family for the others as well, to support Mint and the likes.

In GitLab by @jcgruenhage on Feb 4, 2021, 01:12

Even though this only contains the yggdrasil role right now, I'd like to keep our practice from other collections to use the role or module name as the scope for the conventional commit message. Also, this is more of a bugfix than a chore IMO, so I'd suggest (together with the suggestions in the code comment above) something like fix(yggdrasil): use ansible_os_family instead of ansible_lsb

In GitLab by @Ratzupaltuff on Mar 24, 2021, 20:17

added 1 commit

df52ab55 - fix(yggdrasil): use ansible_os_family instead of ansible_lsb

Compare with previous version

In GitLab by @Ratzupaltuff on Mar 24, 2021, 20:18

resolved all threads

In GitLab by @jcgruenhage on Mar 24, 2021, 21:12

Commented on roles/yggdrasil/tasks/install.yml line 3

have you tested these OS families? On VoidLinux,

- hosts: localhost
  tasks:
    - debug:
        msg: "{{ ansible_os_family }}"

returns

TASK [debug] **********************************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "void"
}

In GitLab by @Ratzupaltuff on Mar 24, 2021, 21:42

Commented on roles/yggdrasil/tasks/install.yml line 3