feat: support for yggrasil 0.4 - [merged] #16

Closed famedly-bot closed 1 year ago

In GitLab by @jcgruenhage on Jul 8, 2021, 14:29

Merges yggdrasil-v0.4 -> main

In GitLab by @jadyn.dev on Jul 8, 2021, 14:37

approved this merge request

In GitLab by @jadyn.dev on Jul 8, 2021, 14:37

unapproved this merge request

In GitLab by @jadyn.dev on Jul 8, 2021, 14:40

Looks good to me, a migration playbook would be nice. It should run secret-rotation for the yggdrasil secret (see https://gitlab.com/famedly/company/devops/collections/local/-/blob/main/playbooks/rotate-host-secrets.yml )and deploy it. I'm not sure if we want to force upgrade yggdrasil each time we run site.yml as it might cause issues if another breaking change comes.

In GitLab by @jadyn.dev on Jul 8, 2021, 14:41

as mentioned, the upgrade should be done in a migration playbook and rather not each time we run site.yml

In GitLab by @jadyn.dev on Jul 8, 2021, 14:42

requested review from @jadyn.dev

In GitLab by @jcgruenhage on Jul 8, 2021, 14:48

That is a good point, will remove those here

In GitLab by @jcgruenhage on Jul 8, 2021, 14:49

regarding a migration playbook: That'll happen, but it won't be part of this MR since it has to go into the environment.

In GitLab by @jcgruenhage on Jul 8, 2021, 14:52