search

famedly / ansible-collection-network

`famedly.network` ansible collection for network-related services (vpn, reverse proxies, ...)
GNU Affero General Public License v3.0
0 stars 1 forks source link

feat(proxy46): add IPv4 to IPv6 proxy - [merged] #20

Closed famedly-bot closed 1 year ago

famedly-bot commented 2 years ago

In GitLab by @lukaslihotzki on Mar 8, 2022, 14:52

Merges ll/proxy46 -> main

https://gitlab.com/famedly/company/devops/containers/proxy46 needs to be reviewed too.

This role is deployed on 46-sni-proxy-test (159.69.145.149, 2a01:4f8:1c1c:a3e5::1). To test it, we need to deploy a host with A record set to 46-sni-proxy-test's IPv4 address and AAAA record set to another IPv6 server.

famedly-bot commented 2 years ago

In GitLab by @lukaslihotzki on Mar 8, 2022, 14:54

added 1 commit

Compare with previous version

famedly-bot commented 2 years ago

In GitLab by @lukaslihotzki on Mar 8, 2022, 14:55

mentioned in issue famedly/company/devops/meta#297

famedly-bot commented 2 years ago

In GitLab by @lukaslihotzki on Mar 14, 2022, 10:09

Synapse seems to block single IP addresses for both IPv4 and IPv6:

$ grep -R getClientIP | grep ratelimit
synapse/rest/client/login.py:                await self._address_ratelimiter.ratelimit(None, request.getClientIP())
synapse/rest/client/login.py:                await self._address_ratelimiter.ratelimit(None, request.getClientIP())
synapse/rest/client/login.py:                await self._address_ratelimiter.ratelimit(None, request.getClientIP())
synapse/rest/client/register.py:        await self.ratelimiter.ratelimit(None, (request.getClientIP(),))

Therefore, the IPv4-mapped IPv6 client addresses from the proxy should behave correctly.

famedly-bot commented 2 years ago

In GitLab by @lukaslihotzki on Aug 22, 2022, 11:35

marked this merge request as ready

famedly-bot commented 2 years ago

In GitLab by @lukaslihotzki on Oct 5, 2022, 14:07

A test server using this proxy is deployed at http://ipv6-only-test.famedly.net/ and https://ipv6-only-test.famedly.net/. Both URLs work with both IPv4 and IPv6. HTTPS has an invalid certificate, but this does not matter for the proxy.

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:16

added 5 commits

Compare with previous version

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:22

added 1 commit

Compare with previous version

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:25

added 1 commit

Compare with previous version

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:25

Commented on roles/proxy46/defaults/main.yml line 2

Is this used anywhere?

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:25

Commented on roles/proxy46/defaults/main.yml line 14

We usually template vars here to use a version unless a tag is explicitly defined and to only force a pull if we specific a tag explicitly. Considering the container image isn't versioned, this is fine for now, but we should follow-up on this.

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:25

Commented on roles/proxy46/tasks/main.yml line 6

Why does the user need to be in the docker group?

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:25

Commented on roles/proxy46/tasks/main.yml line 18

this default is duplicated, 0750 is already in the defaults file.

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 10:25

LGTM in general, just a few small questions

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 14, 2022, 16:37

added 1 commit

Compare with previous version

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:18

Commented on roles/proxy46/defaults/main.yml line 2

changed this line in version 8 of the diff

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:18

Commented on roles/proxy46/tasks/main.yml line 6

changed this line in version 8 of the diff

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:18

Commented on roles/proxy46/tasks/main.yml line 18

changed this line in version 8 of the diff

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:18

added 1 commit

Compare with previous version

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:18

Commented on roles/proxy46/tasks/main.yml line 6

It does not. I removed it from the docker group and it still works.

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:18

Commented on roles/proxy46/defaults/main.yml line 2

No, it can be removed.

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:22

Commented on roles/proxy46/defaults/main.yml line 14

Ok, I created issue #9.

famedly-bot commented 1 year ago

In GitLab by @lukaslihotzki on Dec 19, 2022, 04:23

resolved all threads

famedly-bot commented 1 year ago

In GitLab by @jcgruenhage on Dec 19, 2022, 14:55

approved this merge request