search

famedly / famedly-sync

GNU Affero General Public License v3.0
4 stars 0 forks source link

Phone numbers should be optional #16

Closed tlater-famedly closed 2 months ago

tlater-famedly commented 3 months ago

Currently, phone numbers are mandatory, however it appears that this is was not the intended design.

tlater-famedly commented 3 months ago

Implementation in #13

I realized I never clarified if phone numbers should be optional at a configuration or at an individual-entry level, hence I'm opening this issue to track that.

Currently #13 implements it assuming it should be optional at a configuration level. This means that we will still refuse to sync entries without phone numbers if the tool has a phone attribute set, and never sync phone numbers if it there is no phone attribute.

nikzen commented 3 months ago

Implementation in #13

I realized I never clarified if phone numbers should be optional at a configuration or at an individual-entry level, hence I'm opening this issue to track that.

Currently #13 implements it assuming it should be optional at a configuration level. This means that we will still refuse to sync entries without phone numbers if the tool has a phone attribute set, and never sync phone numbers if it there is no phone attribute.

The tool should always sync the entry. If there is a phone number, it should include the number if not, it should sync what is there