search

famedly / famedly-sync

GNU Affero General Public License v3.0
4 stars 0 forks source link

Add CSV Source #64

Closed jannden closed 1 month ago

jannden commented 1 month ago

Closes #52 , https://github.com/famedly/product-management/issues/2038

github-actions[bot] commented 1 month ago

LCOV of commit d194640 during Rust workflow #376

Summary coverage rate:
  lines......: 86.9% (1139 of 1310 lines)
  functions..: 51.0% (270 of 529 functions)
  branches...: no data found

Files changed coverage rate:
                     |Lines       |Functions  |Branches    
  Filename           |Rate     Num|Rate    Num|Rate     Num
  =========================================================
  src/config.rs      |96.2%    213|57.1%    98|    -      0
  src/sources/csv.rs |93.4%    151|56.7%    60|    -      0
  src/sources/ldap.rs|95.9%    319|59.3%   135|    -      0
  src/user.rs        |89.7%     68|54.5%    22|    -      0
  src/zitadel.rs     |76.7%    317|31.7%   120|    -      0
jannden commented 1 month ago

The requirements were clarified and confirmed with the only stakeholder at the moment - the Marketing team. Task specified https://github.com/famedly/ldap-sync/issues/52 Namely:

emgrav commented 1 month ago

UKF wants a similar feature, apparently. See the linked issue above. I think it would make sense to add fields for organization, project, and role.

Sorry about not catching this issue earlier

nikzen commented 1 month ago

UKF wants a similar feature, apparently. See the linked issue above. I think it would make sense to add fields for organization, project, and role.

Sorry about not catching this issue earlier

@emgrav THis is not required right now for UKF - so we can keep it as it is