Closed famedly-bot closed 1 year ago
In GitLab by @krille-chan on Jan 8, 2022, 10:29
marked this merge request as ready
In GitLab by @krille-chan on Jan 8, 2022, 10:29
marked the checklist item I read the [Contributor Guide] and followed the process outlined there for submitting PRs. as completed
In GitLab by @krille-chan on Jan 8, 2022, 10:29
marked the checklist item I updated/added relevant documentation (doc comments with ///). as completed
In GitLab by @krille-chan on Jan 8, 2022, 10:29
marked the checklist item I did not add or update methods, functions or widgets without tests. as completed
In GitLab by @krille-chan on Jan 8, 2022, 10:30
I have tested it in FluffyChat and can confirm it fixes the bug #260
In GitLab by @Sorunome on Jan 8, 2022, 10:39
Commented on lib/src/client.dart line 1712
soru disagrees with this approach, as then e.g. matrix hq can clog up lots, which was the entire point of that commit which introduced this regression
instead, how about accepting a member event if it is a) invite or b) there are less than 4 or so member events cached
In GitLab by @Sorunome on Jan 8, 2022, 10:42
Commented on lib/src/client.dart line 1712
or maybe invites should not be special-cased and just 4 or so members.
why four? because, if soru recalls correctly, that is the amount of heroes a room can have
In GitLab by @krille-chan on Jan 8, 2022, 10:44
Commented on lib/src/client.dart line 1712
changed this line in version 2 of the diff
In GitLab by @krille-chan on Jan 8, 2022, 10:44
resolved all threads
In GitLab by @krille-chan on Jan 8, 2022, 10:44
added 1 commit
In GitLab by @Sorunome on Jan 8, 2022, 10:46
approved this merge request
In GitLab by @Sorunome on Jan 8, 2022, 10:46
started a merge train
In GitLab by @krille-chan on Jan 8, 2022, 10:47
removed this merge request from the merge train because source branch was updated
In GitLab by @krille-chan on Jan 8, 2022, 10:47
added 1 commit
In GitLab by @krille-chan on Jan 8, 2022, 10:47
enabled automatic add to merge train when the pipeline for 634aec3726e68892c29a5c06ae7d823abb056004 succeeds
In GitLab by @krille-chan on Jan 8, 2022, 10:50
started a merge train
In GitLab by @krille-chan on Jan 8, 2022, 10:53
mentioned in commit d31a594068119058bfe38dd2a0869f7cb251b391
In GitLab by @krille-chan on Jan 8, 2022, 10:24
Merges krille/fix-invite-state -> main
Description
Fixes #260
Checklist