feat: keep timeline history for archive rooms in memory - [merged]

[famedly-bot]

In GitLab by @h.carnot on Apr 8, 2022, 11:54

Merges henri/fix-timeline-history -> main

Description

Fixes #275 #311

For archived rooms, we don't want to store the events in the database. For this, we store the sync response containing all the timeline for the archived rooms in memory and ask explicitly the sync handler to not update the database.

TODO

• [x] : Initial implementation
• [x] : Rewrite requestHistory to not save requested events in the database for archived rooms.
• [x] : Verify that we can decrypt the events without needing to save the event update.
• [x] : What if we are suddenly re-invited in a archived room. See if the timeline is properly discarded.
• [x] : Provide a way to discard _archivedRooms. What if this take too much ram ?
• [x] : Tests

Checklist

• [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• [ ] I updated/added relevant documentation (doc comments with ///).
• [ ] I did not add or update methods, functions or widgets without tests.

[famedly-bot]

In GitLab by @h.carnot on Jun 27, 2022, 17:40

added 1 commit

• dd2b896f - fix: docker image

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jun 27, 2022, 17:44

Commented on .gitlab-ci.yml line 42

needed because https://gitlab.com/famedly/company/frontend/flutter-dockerimages/-/issues/6

[famedly-bot]

In GitLab by @h.carnot on Jun 27, 2022, 17:47

added 1 commit

• cc4f430e - fix: argggggg

Compare with previous version

[famedly-bot]

In GitLab by @nico-famedly on Jun 28, 2022, 13:07

Commented on .gitlab-ci.yml line 42

Should be fixed by https://gitlab.com/famedly/company/frontend/famedlysdk/-/merge_requests/1063

[famedly-bot]

In GitLab by @h.carnot on Jun 28, 2022, 13:53

added 4 commits

• cc4f430e...55417bcc - 3 commits from branch main
• f7f544d5 - feat: keep timeline history

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jun 28, 2022, 14:11

Commented on .gitlab-ci.yml line 42

yep, working, thanks!

[famedly-bot]

In GitLab by @krille-chan on Jul 1, 2022, 09:15

Commented on lib/src/room.dart line 1279

  bool get isArchived => membership == Membership.leave;

[famedly-bot]

In GitLab by @krille-chan on Jul 1, 2022, 09:16

Commented on lib/src/room.dart line 1279

In one of my favorite clean code books, they recommend to try to start every boolean variable name with "is..."

[famedly-bot]

In GitLab by @h.carnot on Jul 8, 2022, 17:19

Commented on lib/src/room.dart line 1279

changed this line in version 24 of the diff

[famedly-bot]

In GitLab by @h.carnot on Jul 8, 2022, 17:19

added 1 commit

• 96612a8f - fix: change isArchived getter name

Compare with previous version

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 02:11

resolved all threads

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 02:12

Commented on test/room_archived_test.dart line 55

Flaky, please avoid sleeps in tests.

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 02:13

resolved all threads

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 02:13

Commented on test/room_archived_test.dart line 55

created #311 to continue this discussion

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 02:14

approved this merge request

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 02:15

Dammit, of course this conflicts now. Can you fix those and maybe #311 as well?

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 12:39

added 40 commits

• 96612a8f...d3936ff3 - 38 commits from branch main
• ddef130b - feat: keep timeline history
• 0e4bddc3 - fix: change isArchived getter name

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 12:43

added 1 commit

• ddc24f9f - fix: remove impoper formating

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 15:37

Commented on lib/src/client.dart line 1705

changed this line in version 27 of the diff

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 15:37

Commented on test/room_archived_test.dart line 55

changed this line in version 27 of the diff

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 15:37

added 1 commit

• 4cc973a8 - fix: race conditions

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 15:39

ok let’s see if it works now. And also, fixed #311

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 15:41

approved this merge request

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 15:42

unapproved this merge request

[famedly-bot]

In GitLab by @nico-famedly on Jul 13, 2022, 15:43

Commented on test/room_archived_test.dart line 136

Can you instead use the tearDown and setUp functions for each test so that they are not interdependent?

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 15:55

added 1 commit

• 7ca98ee7 - fix: removed poison and adde tearDown

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 15:58

added 1 commit

• e70e40e2 - fix: removed waitForCount

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 15:58

Commented on test/room_archived_test.dart line 136

done :)

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 16:54

added 1 commit

• efc8d0ef - fix: room decryption

Compare with previous version

[famedly-bot]

In GitLab by @h.carnot on Jul 13, 2022, 16:55

So I tested in the famedly app, it’s working great. Fixed a encryption issue.

[famedly-bot]

In GitLab by @nico-famedly on Jul 21, 2022, 15:46

approved this merge request

[famedly-bot]

In GitLab by @nico-famedly on Jul 21, 2022, 15:49

added 9 commits

• efc8d0ef...32d84dde - 8 commits from branch main
• 58eb6508 - Merge branch 'main' into 'henri/fix-timeline-history'

Compare with previous version

[famedly-bot]

In GitLab by @nico-famedly on Jul 21, 2022, 15:50

approved this merge request

[famedly-bot]

In GitLab by @nico-famedly on Jul 21, 2022, 15:51

enabled automatic add to merge train when the pipeline for d9811f569a1913024d8e8046749e98ece01f1ed7 succeeds

[famedly-bot]

In GitLab by @nico-famedly on Jul 21, 2022, 15:53

added this merge request to the merge train at position 3

[famedly-bot]

In GitLab by @nico-famedly on Jul 21, 2022, 16:00

removed this merge request from the merge train because pipeline did not succeed

[famedly-bot]

In GitLab by @nico-famedly on Jul 21, 2022, 16:06

added 12 commits

• 58eb6508...f04d8a9f - 4 commits from branch main
• 9c9d1a5b - feat: keep timeline history
• 08ab5f48 - fix: change isArchived getter name
• 82a35671 - fix: remove impoper formating
• 82cc15c7 - fix: race conditions
• c0b3fc02 - fix: removed poison and adde tearDown
• d3892ac8 - fix: removed waitForCount
• 14a36d19 - fix: room decryption
• 4c8ba4af - fix: sort imports

Compare with previous version

[famedly-bot]

In GitLab by @Techno-Disaster on Jul 21, 2022, 16:11

approved this merge request

[famedly-bot]

In GitLab by @Techno-Disaster on Jul 21, 2022, 16:11

started a merge train

[famedly-bot]

In GitLab by @Techno-Disaster on Jul 21, 2022, 16:14

mentioned in commit 75b825742e02383980a84368aa10cfdd54e4f77a

[famedly-bot]

In GitLab by @nikzen on Oct 11, 2022, 10:43

mentioned in issue undefined##undefined