search

famedly / matrix-dart-sdk

Matrix SDK written in pure Dart.
GNU Affero General Public License v3.0
58 stars 31 forks source link

feature: room timeline reference #1892

Open WilsonLe opened 1 month ago

WilsonLe commented 1 month ago

Improve run time of getTimeline by introducing a mutable reference to it inside a room instance. Only create new timeline instance if the chunks are different, otherwise reuse existing one.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: WilsonLe
:x: wcjord
You have signed the CLA already but the status is still pending? Let us recheck it.

nico-famedly commented 1 week ago

This seems to include the space hierarchy changes, which makes it hard to review, could you remove those patches from this PR?