fix: when parsing a 'react' command, try to convert custom emote name to MXC URL

famedly / matrix-dart-sdk

Matrix SDK written in pure Dart.

GNU Affero General Public License v3.0

58 stars 31 forks source link

fix: when parsing a 'react' command, try to convert custom emote name to MXC URL #1894

Open ggurdin opened 1 month ago

ggurdin commented 1 month ago

Hello! It looks like the rendering logic for some clients (I'm thinking specifically at fluffychat) is expecting the key for custom emote reaction events to be the URL for the emote image. This addition parses the custom emote name into its corresponding URL before sending the event.

nico-famedly commented 1 week ago

This looks reasonable to me, could you also add a test for it?