fix: SQLCipher dylib location on macOS builds

famedly / matrix-dart-sdk

Matrix SDK written in pure Dart.

GNU Affero General Public License v3.0

62 stars 31 forks source link

fix: SQLCipher dylib location on macOS builds #1904

Closed TheOneWithTheBraid closed 2 months ago

TheOneWithTheBraid commented 2 months ago

I guess no one ever noticed, but obviously the path of the SQLCipher build on macOS is relative to the build app on macOS. I double checked in both release and debug mode, this is the correct path for the SQLCipher dylib on macOS. The Current in the path defines it automatically chooses the matching one whether on aarch64 or amd64.

TheOneWithTheBraid commented 2 months ago

@nico-famedly CI fails but on a completely unrelated test, could you have a look at it ?

nico-famedly commented 2 months ago

@TheOneWithTheBraid, CI failures are unrelated:

the coverage report does not work for external PRs apparently
The dendrite job is marked as allowed to fail