#52 ⁃ Space children must have `via` field to be valid

[famedly-bot]

In GitLab by @krille-chan on Sep 1, 2021, 11:51

We should check if a space child has a via field before we return it in the Room.spaceChildren getter. https://spec.matrix.org/v1.4/client-server-api/#mspacechild says:

via [string]
A list of servers to try and join through. See also: Routing.

When not present or invalid, the child room is not considered to be part of the space.

Also we can make the via field non-nullable. This can be done very easily in under a hour I would say.

• [x] The issue title and description should be explained in English language.
• [ ] Feature request is provided in story template:
• [ ] Business value is clear and understood.
• [x] Every attached media (if applicable) should include a short description.
• [x] Engineer has confirmed this feature is technically feasible.

[famedly-bot]

In GitLab by @nikzen on Oct 5, 2022, 12:39

@krille-chan Please add a detailed description to the issue using one of the templates.

[famedly-bot]

In GitLab by @MarkTalh on Dec 8, 2022, 15:55

marked the checklist item The issue title and description should be explained in English language. as completed

[famedly-bot]

In GitLab by @MarkTalh on Dec 8, 2022, 15:55

marked the checklist item Every attached media (if applicable) should include a short description. as completed

[famedly-bot]

In GitLab by @MarkTalh on Dec 8, 2022, 15:55

marked the checklist item Engineer has confirmed this feature is technically feasible. as completed

[famedly-bot]

In GitLab by @MarkTalh on Dec 8, 2022, 15:58

@famedly/chapter-frontend Please provide a story template:

As a — I want — So that —

Please elaborate more on the value for users.

[famedly-bot]

In GitLab by @nico-famedly on Dec 8, 2022, 16:02

As a developer I want the space listing code to follow the spec, so that we can actually properly remove space children from a space instead of those getting stuck potentially forever.