search

famedly / uia-proxy

GNU Affero General Public License v3.0
0 stars 0 forks source link

feat(sso): Spec compatibility hack - [merged] #116

Closed famedly-bot closed 1 year ago

famedly-bot commented 2 years ago

In GitLab by @agraven on Aug 11, 2022, 06:53

Merges agraven/get-compat -> main

Advertise m.login.sso in GET /login if it's enabled

Closes #24

famedly-bot commented 2 years ago

In GitLab by @agraven on Aug 11, 2022, 06:53

requested review from @jdreichmann

famedly-bot commented 2 years ago

In GitLab by @agraven on Aug 11, 2022, 08:38

cc @nikzen @jdreichmann

famedly-bot commented 2 years ago

In GitLab by @jdreichmann on Aug 11, 2022, 10:50

Commented on src/stagehandler.ts line 224

As the client needs to be able to find the redirect URL out of this, this needs to include the idp ID with a displayName, analog to synapse:

      "identity_providers": [                                                                                                          
        {                                                                                                                              
          "id": "oidc-famedly",                                                                                                             
          "name": "Famedly IDP"                                                                                                      
        }                                                                                                                              
      ]
famedly-bot commented 2 years ago

In GitLab by @agraven on Aug 11, 2022, 11:30

Commented on src/stagehandler.ts line 224

changed this line in version 2 of the diff

famedly-bot commented 2 years ago

In GitLab by @agraven on Aug 11, 2022, 11:30

added 1 commit

Compare with previous version

famedly-bot commented 2 years ago

In GitLab by @agraven on Aug 11, 2022, 11:30

Commented on src/stagehandler.ts line 224

It now outputs

{
  "flows": [
    {
      "type": "com.famedly.login.msc2835"
    },
    {
      "type": "m.login.sso",
      "identity_providers": [
        {
          "id": "foo",
          "name": "foo" 
        }
      ]
    }
  ]
}

Where foo is the configured ID. I hope that suffices.

famedly-bot commented 2 years ago

In GitLab by @agraven on Aug 11, 2022, 13:00

added 1 commit

Compare with previous version

famedly-bot commented 2 years ago

In GitLab by @jdreichmann on Aug 11, 2022, 13:59

approved this merge request