famedly / uia-proxy

GNU Affero General Public License v3.0
0 stars 0 forks source link

feat: Add ability to add differently configured aliased stages - [merged] #147

Closed famedly-bot closed 1 year ago

famedly-bot commented 1 year ago

In GitLab by @kate-shine on Mar 2, 2023, 11:46

_Merges shine/ability_to_add_aliased_stageconfigs -> main

closes https://gitlab.com/famedly/company/product-management/-/issues/634\

Adds ability to set aliases for stages and load them with different configuration Removal of special cases that aren't necessary anymore

famedly-bot commented 1 year ago

In GitLab by @kate-shine on Mar 2, 2023, 11:46

requested review from @ghost, @ghost, and @jdreichmann

famedly-bot commented 1 year ago

In GitLab by @ghost1 on Mar 2, 2023, 11:46

Thank you for your merge request and welcome to Famedly. We require contributors to sign our Contributor License Agreement, and we don't seem to have the user Kateřina Churanová on file. In order for us to review and merge your code, please sign our Contributer License Agreement.

Please visit Link to CLA to sign.

Once you've signed, we will start with the review process.

famedly-bot commented 1 year ago

In GitLab by @nikzen on Mar 2, 2023, 11:58

@kate-shine Can you send me your commit mail?

famedly-bot commented 1 year ago

In GitLab by @ghost1 on Mar 2, 2023, 12:03

Thank you for your merge request and welcome to Famedly. We require contributors to sign our Contributor License Agreement, and we don't seem to have the user Kateřina Churanová on file. In order for us to review and merge your code, please sign our Contributer License Agreement.

Please visit Link to CLA to sign.

Once you've signed, we will start with the review process.

famedly-bot commented 1 year ago

In GitLab by @nikzen on Mar 2, 2023, 12:07

@group_4616224_bot_0081ddb2619a50be check

famedly-bot commented 1 year ago

In GitLab by @kate-shine on Mar 2, 2023, 12:11

added 1 commit

Compare with previous version

famedly-bot commented 1 year ago

In GitLab by @ghost on Mar 2, 2023, 18:39

approved this merge request

famedly-bot commented 1 year ago

In GitLab by @ghost on Mar 8, 2023, 06:47

Commented on src/stagehandler.ts line 340

Could res be given a more descriptive name?

famedly-bot commented 1 year ago

In GitLab by @ghost on Mar 8, 2023, 06:47

Just one minor nit, looks good!

famedly-bot commented 1 year ago

In GitLab by @kate-shine on Mar 8, 2023, 12:42

Commented on src/stagehandler.ts line 340

changed this line in version 3 of the diff

famedly-bot commented 1 year ago

In GitLab by @kate-shine on Mar 8, 2023, 12:42

added 1 commit

Compare with previous version

famedly-bot commented 1 year ago

In GitLab by @ghost on Mar 8, 2023, 12:43

approved this merge request

famedly-bot commented 1 year ago

In GitLab by @kate-shine on Mar 8, 2023, 12:43

marked this merge request as ready

famedly-bot commented 1 year ago

In GitLab by @kate-shine on Mar 8, 2023, 12:43

enabled an automatic merge when the pipeline for 5b7d6a80f19ab67eb71e29deb0e034f8e3a26d9c succeeds

famedly-bot commented 1 year ago

In GitLab by @jdreichmann on Mar 13, 2023, 09:57

mentioned in issue undefined##undefined