fix: don't escape uppercase characters in ldapEscape - [merged] #151

Closed famedly-bot closed 1 year ago

In GitLab by @kate-shine on May 9, 2023, 18:58

_Merges shine/ldap_escapefix -> 0.7

In GitLab by @kate-shine on May 9, 2023, 19:11

added 1 commit

067e7d0f - fix: don't escape uppercase characters in ldapEscape

Compare with previous version

In GitLab by @kate-shine on May 9, 2023, 20:02

mentioned in issue undefined##undefined

In GitLab by @kate-shine on May 9, 2023, 20:04

fixes https://gitlab.com/famedly/company/product-management/-/issues/977

In GitLab by @ghost on May 10, 2023, 07:41

Commented on src/passwordproviders/passwordprovider_ldap.ts line 342

So this is meant to be used with mxids, right? Afaict, it's incorrectly used in several other places too, including for usernames that we stick in the database, so there's a risk that changing how this function works will break a lot of things elsewhere. We will need to test very thoroughly if we go through with this change.

In GitLab by @ghost on May 10, 2023, 09:20

Approved after discussion

In GitLab by @ghost on May 10, 2023, 09:20

approved this merge request

In GitLab by @ghost on May 10, 2023, 09:20

resolved all threads

In GitLab by @jdreichmann on May 10, 2023, 15:44

We need this in main/0.8.x aswell..

In GitLab by @jdreichmann on May 10, 2023, 15:47

see https://gitlab.com/famedly/company/backend/services/uia-proxy/-/blob/main/src/passwordproviders/passwordprovider_ldap.ts#L437 (main) (@kate-shine)

In GitLab by @jcgruenhage on May 10, 2023, 15:50

mentioned in issue undefined##undefined

In GitLab by @kate-shine on May 10, 2023, 17:20

Yep, I knew about it, I just thought UKF needs 0.7 and rushed that one more. I hate split versions :/

famedly / uia-proxy

fix: don't escape uppercase characters in ldapEscape - [merged] #151