famedly / uia-proxy

GNU Affero General Public License v3.0
0 stars 0 forks source link

UIA Proxy should not crash on upstream OP errors #31

Closed famedly-bot closed 1 year ago

famedly-bot commented 2 years ago

In GitLab by @jdreichmann on Sep 15, 2022, 06:57

Letting UIA proxy stacktrace and crash for every random upstream error is not good practice and can lead to complicated transient problems as the routes are down during the restart, and traffic begins to hit the wrong endpoints.

Sep-14 11:18:17.163 [OpenID] info: Initializing new OpenID code login flow with id t1Q64qJZxxxPzVWE0_7S5IIIO7q-9aTIcP2L8TzRuM0                                                                                                                                                 
Sep-14 11:18:17.484 [OpenID] info: Received callback for OpenID login session t1Q64qJZxxxPzVWE0_7S5IIIO7q-9aTIcP2L8TzRuM0                                                                                                                                                      

/opt/uia-proxy/node_modules/openid-client/lib/client.js:427                                                                                                                                                                                                                    
      throw new OPError(params);                                                                                                                                                                                                                                               
            ^                                                                                                                                                                                                                                                                  
OPError: login_required (prompt for additional authentication factor required, but forbidden by prompt parameter none)                                                                                                                                                         
    at Client.callback (/opt/uia-proxy/node_modules/openid-client/lib/client.js:427:13)                                                                                                                                                                                        
    at OidcProvider.<anonymous> (/opt/uia-proxy/src/stages/com.famedly.login.sso/openid.js:188:51)                                                                                                                                                                             
    at Generator.next (<anonymous>)                                                                                                                                                                                                                                            
    at /opt/uia-proxy/src/stages/com.famedly.login.sso/openid.js:9:71                                                                                                                                                                                                          
    at new Promise (<anonymous>)                                                                                                                                                                                                                                               
    at __awaiter (/opt/uia-proxy/src/stages/com.famedly.login.sso/openid.js:5:12)                                                                                                                                                                                              
    at OidcProvider.oidcCallback (/opt/uia-proxy/src/stages/com.famedly.login.sso/openid.js:182:16)                                                                                                                                                                            
    at Oidc.<anonymous> (/opt/uia-proxy/src/stages/com.famedly.login.sso/openid.js:110:53)                                                                                                                                                                                     
    at Generator.next (<anonymous>)                                                                                                                                                                                                                                            
    at /opt/uia-proxy/src/stages/com.famedly.login.sso/openid.js:9:71 {                                                                                                                                                                                                        
  error: 'login_required',                                                                                                                                                                                                                                                     
  error_description: 'prompt for additional authentication factor required, but forbidden by prompt parameter none',                                                                                                                                                           
  state: 't1Q64qJZxxxPzVWE0_7S5IIIO7q-9aTIcP2L8TzRuM0'                                                                                                                                                                                                                         
}