fix: Prevent memory leak - [merged] #53

Closed famedly-bot closed 1 year ago

In GitLab by @agraven on Jun 4, 2021, 14:11

Merges agraven/memory-leak -> main

Fix TimedCache instances leaking memory by adding a timer to the TimedCache which runs every 10 seconds and deletes values whose times have expired.

Closes https://gitlab.com/famedly/company/issue-inbox/-/issues/55.

In GitLab by @agraven on Jun 4, 2021, 14:20

added 2 commits

f3a9fb40 - fix: Prevent memory leak
d638a229 - fix: Fix lint error by moving literal to constant

Compare with previous version

In GitLab by @kate-shine on Jun 4, 2021, 14:39

requested review from @jbecker and @jdreichmann

In GitLab by @jbecker on Jun 4, 2021, 14:42

Commented on src/structures/timedcache.ts line 2

disable-next-line might work as well

In GitLab by @jbecker on Jun 4, 2021, 14:43

e2e tests failing are blocked behind https://gitlab.com/famedly/company/devops/environments/dev/-/issues/32, other than that this looks good to me

In GitLab by @jbecker on Jun 4, 2021, 14:43

approved this merge request

In GitLab by @agraven on Jun 4, 2021, 14:49

marked this merge request as ready

In GitLab by @agraven on Jun 4, 2021, 14:50

Commented on src/structures/timedcache.ts line 2

I figured a disable/enable pair would be better in case additional constants are added in the future.

In GitLab by @jbecker on Jun 4, 2021, 16:12

resolved all threads

In GitLab by @jdreichmann on Jun 8, 2021, 09:16

approved this merge request

In GitLab by @jdreichmann on Jun 8, 2021, 09:18

LGTM, the e2ee tests will still take a while because https://gitlab.com/famedly/company/devops/meta/-/issues/109 has still a lot of stuff open...

In GitLab by @jbecker on Jun 8, 2021, 09:21

Just a small note since I saw that in the linked issue as well: "e2ee tests" would mean encryption tests, "e2e" is just end-to-end which is common test terminology

In GitLab by @jbecker on Jun 28, 2021, 09:48

mentioned in issue famedly/company/issue-inbox#55

In GitLab by @agraven on Jul 12, 2021, 13:38

added 3 commits

942e1276 - 1 commit from branch main
43c33966 - fix: Prevent memory leak
e5a01ab1 - fix: Fix lint error by moving literal to constant

Compare with previous version

In GitLab by @jbecker on Jul 16, 2021, 12:29

added 5 commits

e5a01ab1...a651f8b1 - 3 commits from branch main
a7fcc1ae - fix: Prevent memory leak
38aeea64 - fix: Fix lint error by moving literal to constant

Compare with previous version

In GitLab by @jbecker on Jul 16, 2021, 12:29

enabled an automatic merge when the pipeline for 38aeea64df7e603036025ae585ce2a90724f81d8 succeeds

In GitLab by @jbecker on Jul 16, 2021, 12:29

resolved all threads

famedly / uia-proxy

fix: Prevent memory leak - [merged] #53