search

famsf / pecl-pdo-4d

SVN->Git of the PHP PECL PDO 4D extension http://svn.php.net/repository/pecl/pdo_4d/ plus bugfixes
3 stars 12 forks source link

fixes page size bug, limiting to 100 rows #3

Open jasonpjohnson opened 8 years ago

jasonpjohnson commented 8 years ago

add first page size fixes bug that limits 100 rows, this was tested to 2 mil rows even though the page size is set at 999999

13rac1 commented 8 years ago

This looks to be the fix suggested in: https://bugs.php.net/bug.php?id=63896 Since this is not the canonical repository for this extension's code can you amend the commit message to contain a link to the bug listing?

@jasonpjohnson I don't work at FAMSF any longer, so I don't have access to a 4D install to test. I'll see if I can get it tested/merged. @andrewtf I've compiled. One test was already failing and continues to fail. Looks good otherwise. Can you test then merge?

jasonpjohnson commented 8 years ago

I have this code out in production now on 4D v13, works perfectly even though I set the limit at 999999 I was able to run a query and return 2.9 million rows.

make test has always failed for me.

13rac1 commented 8 years ago

Ok. @andrewtf must confirm your results. :) Thanks!

13rac1 commented 8 years ago

@jasonpjohnson Can you rebase these branches to remove the extra commits, the separate formatting change commit, and set your git author correctly (says root right now)? I don't understand whats going on with: https://github.com/jasonpjohnson/pecl-pdo-4d/commit/cc22cb0abca34586b57d288d2b2d60b314080f94 It is showing 84k new lines.