famuvie / breedR

Statistical methods for forest genetic resources analysts
http://famuvie.github.io/breedR/
GNU General Public License v3.0
31 stars 24 forks source link

Reporting inner or full knots #41

Open famuvie opened 9 years ago

famuvie commented 9 years ago

In the splines model, the user specifies the number of inner knots by rows and columns. However, in the summary() of results, breedR reports the total number of knots (i.e. inner + 6 in each dimension). This is confusing as long as it is not explicit. Should breedR ask and show the inner number of knots to avoid confusions? Moreover, would it be more natural to deal with the number of splines (inner + 2) in the base rather than with the number of knots?