fancho29 / garglk

Automatically exported from code.google.com/p/garglk
Other
0 stars 0 forks source link

Parameter declarations of function my_malloc differ in signedness #209

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Debian package version: 2011.1a-2

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
Link build/linux.release/geas/geas 
build/linux.release/garglk/libgarglk.a(sndsdl.o): In function 
`glk_schannel_play_ext':
sndsdl.c:(.text+0xd21): warning: the use of `tempnam' is dangerous, better use 
`mkstemp'

error: conflicting function declarations "my_malloc"
old definition in module babel_handler file support/babel/babel_handler.c line 
186
void * (signed int, char *)
new definition in module misc file support/babel/misc.c line 12
void * (unsigned int size, char *rs)

Observe the difference in the first parameter; this will only be safe as long 
as all values remain sufficiently small. Even if it is, this should be fixed to 
ensure the compiler can generate appropriate diagnostics.

Best,
Michael

Original issue reported on code.google.com by michael....@gmail.com on 13 Jun 2014 at 2:12