fancyapps / fancybox

jQuery lightbox script for displaying images, videos and more. Touch enabled, responsive and fully customizable.
http://fancyapps.com/
7.28k stars 1.78k forks source link

bower.json discrepancy #1059

Closed andreigec closed 7 years ago

andreigec commented 9 years ago

bower.json in bower repo is different, missing main element at the minimum.

bower.json from github: { "name": "fancybox", "version": "2.1.5", "main": [ "source/jquery.fancybox.css", "source/jquery.fancybox.js", "source/blank.gif", "source/fancybox_loading.gif", "source/fancybox_loading@2x.gif", "source/fancybox_overlay.png", "source/fancybox_sprite.png", "source/fancyboxsprite@2x.png", "source/jquery.fancybox.pack.js" ], "ignore": [ "*/._", "fancybox.jquery.json", "demo" ], "dependencies": { "jquery": ">=1.10", "jquery-mousewheel": "~3.1.3" } }

bower.json from bower/fancybox#2.1.5 { "name": "fancybox", "homepage": "https://github.com/fancyapps/fancyBox", "version": "2.1.5", "_release": "2.1.5", "_resolution": { "type": "version", "tag": "v2.1.5", "commit": "18d171278d21ca59067aace6d52a1adeb6462219" }, "_source": "git://github.com/fancyapps/fancyBox.git", "_target": "~2.1.5", "_originalSource": "fancybox" }

ghost commented 9 years ago

+1

Horttcore commented 8 years ago

+1

Horttcore commented 8 years ago

Install via

bower install fancybox#master

conantp commented 8 years ago

@Horttcore - thanks for the tip, that helped me out using Fancybox with Sage 8 for Wordpress.

One issue I'm still having is that the image URLs in the CSS don't match up when I use "gulp" and "asset-builder" - I had to manually re-write them in the CSS. I think that's something that should be addressed outside of this package but other than that everything works great.

fancyapps commented 7 years ago

Duplicate of #820