search

fancyapps / fancybox

jQuery lightbox script for displaying images, videos and more. Touch enabled, responsive and fully customizable.
http://fancyapps.com/
7.28k stars 1.78k forks source link

Proposal for smaller Share buttons #2167

Open acwolff opened 5 years ago

acwolff commented 5 years ago

The current Share buttons are too large for small devices as I showed in #2116.

I saw recently a nice solution in this album: fb-sharemenuproposal

Could you please implement this kind of display in your next version?

It would also be nice if you added sharing by email and makes it easy extend-able with more shore functions.

mjcampagna commented 5 years ago

Hi André,

That's me. As you can perhaps tell by my implementation, I've done quite a few customizations. The actions pallet above is basically written as an extension or module, so it's basically plug-and-play with the core Fancybox. Both CSS and JS are uncompressed on my site; as long as you're not using it for commercial purpose, I don't mind you inspecting the code.

acwolff commented 5 years ago

Yes Matthew, I like your solution! I did invest already your code, but it is too complicated for me. I use as far as possible fancybox 3.5, so it would be nice if this could be implemented in the next version. The current Share implementation is not ideal, so if your solution is added, the problems are solved and all users of fancybox may use it. I am missing also sharing via email in your implementation and your share button is strange in my opinion, I think the standard fancybox share button is better to understand. I don’t understand the function of your last share function/button!

mjcampagna commented 5 years ago

It includes sharing links, but also an image permalink, a download button, and -- if the image has a geolocation -- a link to Google Maps. So in my case, it's not just a Share menu, and therefore I style it as an "Image" menu, hence the icon I've chosen.

I don't know what you level of Javascript is, but in designing the extension, I looked at Janis' included module for the Thumbnails pallet. It made a good starting point learning how to extend Fancybox.