fancyapps / fancybox

jQuery lightbox script for displaying images, videos and more. Touch enabled, responsive and fully customizable.
http://fancyapps.com/
7.28k stars 1.78k forks source link

iPad thumbnail bar issue when using echo.js #2353

Open alixbergeret opened 4 years ago

alixbergeret commented 4 years ago

i have a strange issue that is only happening on iPad, with the thumbnail bar open on the right, and I tap on random images... the big image on the left doesn’t ALWAYS get display full size... it doesn't happen often, i need to keep tapping around the thumbnail bar for a while before it happens:

31056250-1CE7-41D3-9641-17D4E3DC79AB

If I navigate away and back using the left and right arrows (ie not the thumbnail bar) the image is back to its normal size.

D2A21F93-9A71-4208-A8CA-90A0B3C5585C

This is baffling. It only happens on iPad, so i can’t debug using the dev tools... also it only seems to happen with large galleries, and only when navigating using the thumbnails... and again, only occasionally.

I am on iOS 12.4.1 Latest version of Chrome.

Any Idea?

fancyapps commented 4 years ago

Hi,

Does this happen on Chrome only or on Safari as well?

alixbergeret commented 4 years ago

Hi,

Thank you for your message.

Yes it happens on Safari as well. Please note that since yesterday I have installed the latest version on iOS(13.1.2) and it has NOT fixed the issue.

A few more thoughts:

$('[data-fancybox="gallery"]').fancybox({ buttons : [ "zoom", "share", "fullScreen", "download", "thumbs", "close" ], transitionEffect: "slide", loop: true, thumbs : { autoStart : true } });

Let me know if I can provide anything else (a video of the issue?), as this is really bugging me, the thumbnail bar is an important feature on my website.... thanks!

alixbergeret commented 4 years ago

I have done a video showing the issue :)

https://www.youtube.com/watch?v=_NPcj7i_zLg

alixbergeret commented 4 years ago

A quick update.

It does indeed seem to be the use of the "data-thumb" attribute that is causing the problem. If I remove it:

So... clearly the fact that I use the "data-thumb" is upsetting the code further down... but where? Maybe in the setBigImage function? it's so hard to know without being able to debug the code :(

fancyapps commented 4 years ago

Hard to tell without seeing your page, works fine for me.

alixbergeret commented 4 years ago

Hi, Fair enough, I have activated the thumbnails on this comics series only: https://www.bdtheque.com/series/126/thorgal

To replicate the issue (on iPad) :

I hope this helps.

fancyapps commented 4 years ago

Oh, man, you know, no matter how hard I tried, I followed exactly all your steps on the video, and it just works fine on my iPad.

Could you try to disable transition effect (transitionEffect:false) to see if that helps you?

alixbergeret commented 4 years ago

Hi, Thank you for looking into it. I have tried disabling the transition effect, but that didn't fix it. Please note that I have isolated the issue on a simplified test page, to ensure the problem isn't caused by something else (I don't know Bootstrap for example). Here it is: http://mi-linux.wlv.ac.uk/~in9352/test.php

And I can replicate the issue on my iPad, but also on my old iPhone 5.

If you look at the code, I have only included the bare minimum.

As per before:

I was hoping it could just be my iPad, but now I can replicate on my iPhone too, so it worries me :(

acwolff commented 4 years ago

I see the issue on my iPad, but only if I click on a thumbnail in the left column, clicking on thumbnails of the right column show correct images.

alixbergeret commented 4 years ago

I see the issue on my iPad, but only if I click on a thumbnail in the left column, clicking on thumbnails of the right column show correct images.

Thank goodness it's not just me, I thought I was losing it.

acwolff commented 4 years ago

Yes but to see the issue I have not just to click some thumbnails on the first page, I have to scroll the thumbnails down to another set before I see the issue.

In my own albums I have the thumbnails at the bottom and I don’t see there the issue, see here. Did you try that?

alixbergeret commented 4 years ago

Yes but to see the issue I have not just to click some thumbnails on the first page, I have to scroll the thumbnails down to another set before I see the issue.

In my own albums I have the thumbnails at the bottom and I don’t see there the issue, see here. Did you try that?

Yes I have mentioned above, and in the video, the issue only happens in a very specific set of circumstances:

But the above are pretty common with the average user to be honest. We had no trouble coming across this.

fancyapps commented 4 years ago

Hi,

Thanks for the minimal demo, that really helps to debug. So, could you, please, open http://fancyapps.com/tmp/echo/ (it is the same site as yours, I just modified a bit echo.js and upgraded jQuery to the latest) and check if that now works fine for you? If yes, then I think I know what is the cause of this issue.

acwolff commented 4 years ago

I do see the issue in demo http://fancyapps.com/tmp/echo/ if I click the 2nd thumbnail in the left column at the end.

FB-iPadProblem

alixbergeret commented 4 years ago

Hi,

Thanks for the minimal demo, that really helps to debug. So, could you, please, open http://fancyapps.com/tmp/echo/ (it is the same site as yours, I just modified a bit echo.js and upgraded jQuery to the latest) and check if that now works fine for you? If yes, then I think I know what is the cause of this issue.

Unfortunately it hasn't fixed... see latest video: https://youtu.be/3BwPMBDZ-0g

Please note that in the video i explain something else I have noticed, that may be of use.

Thank you for your time :)