search

fancyapps / ui

A library of JavaScript UI components, includes the best lightbox - Fancybox5
https://fancyapps.com/
Other
723 stars 91 forks source link

Slideshow does not wait for video #246

Open ron4mac opened 2 years ago

ron4mac commented 2 years ago

When running the slideshow, items such as video or audio are not allowed to complete before advancing the slideshow. Note: worked okay in version 3 but version 3 has a bug that it advances the slide for video even when not in slideshow mode. Also note as well: video slide does not advance when using keyboard arrows(solved by using autoFocus=false)

sjd23 commented 1 week ago

I'll add this note here since the other issue was closed:

I found this comment where it was stated that this is not a problem anymore, and the old jsfiddle provided seems to support that idea. This is not the case with 5.0. Is this because a bug was introduced that incidentally removed the support OR was it an intentional feature removal/omission in the later releases?

"Hi,

Slideshow now waits for html5 video to end (starting from v3.4.1)"

(from: https://github.com/fancyapps/fancybox/issues/1983#issuecomment-417657084)

fancyapps commented 1 week ago

@sjd23 If you have not noticed, this is a completely different project. Fancyapps UI is the successor of the Fancybox project, it was written from scratch and has already been rewritten a couple of times and is now in development for the next major version.

sjd23 commented 1 week ago

@fancyapps Of course. I didn't read through the commit history but assumed it was initially ported here as the readme of that repository provides this detail:

"This repository has been archived and is now part of https://github.com/fancyapps/ui"

The feature being gone makes sense to me now though. Thank you.