Slideshows aren't waiting for videos anymore

sjd23 commented 5 months ago

Describe the bug

The slideshow continues when there is html5 video playing. I found this comment where it was stated that this is not a problem anymore, and the old jsfiddle provided seems to support that idea. This is not the case with 5.0:

"Hi,

Slideshow now waits for html5 video to end (starting from v3.4.1)"

https://github.com/fancyapps/fancybox/issues/1983#issuecomment-417657084

Reproduction

Add an html5 video to a gallery and press the slideshow's play button

Additional context

No response

fancyapps commented 5 months ago

Duplicate of #246

sjd23 commented 5 months ago

While true, it doesn't call out that this was a feature intentionally added a while back that isn't working right now. So it's either a bug or something someone intentionally removed and could hopefully speak to, right?

On Thu, Jun 20, 2024, 4:00 AM Jānis Skarnelis @.***> wrote:

Duplicate of #246 https://github.com/fancyapps/ui/issues/246

— Reply to this email directly, view it on GitHub https://github.com/fancyapps/ui/issues/664#issuecomment-2180055407, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCVC4Z7QDZR2O3B7QPWFOVTZIKDYBAVCNFSM6AAAAABJSZONCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGA2TKNBQG4 . You are receiving this because you authored the thread.Message ID: @.***>

fancyapps / ui