fancyapps / ui

A library of JavaScript UI components, includes the best lightbox - Fancybox5
https://fancyapps.com/
Other
819 stars 98 forks source link

Enhancements to combined modules (index.js) #681

Open devjam1n opened 3 months ago

devjam1n commented 3 months ago

Is your feature request related to a problem? Please describe.

Yes, there's an issue with the current distribution of index.esm.js and index.umd.js. Even though Thumbs module is included in the code (as it is required by Fancybox), it is not exported. This oversight requires importing thumbs module again leading to redundant code.

Describe the solution you'd like

Include the Thumbs module in the exports at the bottom of both the index.esm.js and index.umd.js files, alongside Carousel, Fancybox, and Panzoom.

Update the official documentation and CDN instructions to reflect that all these modules can be used in a bundled way if you need all of them and performance is critical.

Describe alternatives you've considered

No response

Additional context

No response