fancyapps / ui

A library of JavaScript UI components, includes the best lightbox - Fancybox5
https://fancyapps.com/
Other
780 stars 97 forks source link

Stacking window 'message' event listeners #682

Open ExileofAranei opened 3 weeks ago

ExileofAranei commented 3 weeks ago

Describe the bug

Hi, just noticed that Html plugin does not remove it's listener for message event, plugin's detach function is not called on fancybox destroy so window.removeEventListener is also never called. It tends to adding listeners for such event on each fancybox opening. Sure it won't cause serious performance issues, but it worths mentioning anyway

Tested on my websites with latest version, screenshot is captured on yours image

Reproduction

Open fancybox multiple times and check listeners for message event

Additional context

No response

fancyapps commented 3 weeks ago

Hi, Thanks for the reporting!