fandrei / AppMetrics

Apache License 2.0
8 stars 2 forks source link

Log more detail about failing requests #94

Closed mrdavidlaing closed 12 years ago

mrdavidlaing commented 12 years ago

The full error message being returned from the PPE tradingAPI whilst the price history service /market/400616150/barhistory?interval=MINUTE&span=1&pricebars=20 was broken was:

  {"ErrorCode":4011,"ErrorMessage":"Session is not valid","HttpStatus":401}

Yet the only details logged in AppMetrics were (http://metrics.labs.cityindex.com/GetRecords.ashx?Application=CIAPILatencyCollector&StartTime=2012-07-10+16%3A53%3A00&EndTime=2012-07-10+17%3A00%3A00)

2012-07-10 16:53:44.8590000 Latency CIAPI.LogIn 0.3345818
2012-07-10 16:53:45.1280000 Latency CIAPI.GetClientAndTradingAccount    0.2684863
2012-07-10 16:53:45.7890000 Latency CIAPI.ListSpreadMarkets 0.6611894
2012-07-10 16:53:46.8150000 Latency CIAPI.ListNewsHeadlinesWithSource   1.0260803
2012-07-10 16:53:47.1130000 Latency CIAPI.GetMarketInformation  0.2981096
2012-07-10 16:54:27.5230000 Exception   Server error\r\n\r\n\r\n
2012-07-10 16:54:27.8120000 Latency CIAPI.LogOut    0.289286

The Appmetrics logs should include more details as to which call caused the error, and what the error message was

fandrei commented 12 years ago

This is due to ReliableHttpException not reporting full inner exception info https://github.com/cityindex/CIAPI.CS/issues/181

fandrei commented 12 years ago

fixed after update to new CIAPI.CS