search

fandreuz / tui-website

4 stars 2 forks source link

Reject theme.xml or suggestions.xml if it's equal to the default one #24

Open fandreuz opened 7 years ago

fandreuz commented 7 years ago

I see so many themes that are "tests", just to know if the mechanism works. But it's a bad thing to have many themes similar or equals to the default one. Is there a way to check if nothing was changed inside a theme?

stagfoo commented 7 years ago

yer, i was thinking about this too. should we just check if they are duplicates of default or any theme? I think I would do this as a clean up task under the firebase functions area (so its not slowing down the front end) and it have a check each month for duplicates and delete them.

fandreuz commented 7 years ago

Actually I'm checking it almost everyday and deleting duplicates. I think that about 2 themes per day are duplicate of default. Is there a limitation on time you can run a clean up task on firebase?

stagfoo commented 7 years ago

I think its 250 operation a month, so we could run it daily

fandreuz commented 7 years ago

Nice!