search

fandreuz / tui-website

4 stars 2 forks source link

Remove show_battery, show_ram, etc... #29

Open fandreuz opened 7 years ago

fandreuz commented 7 years ago

I would like to remove these button, because it's better to discourage this behavior: to create only personal themes, thinking that who use it will disable time, ram, etc. This leads to themes that don't let the user see a label because it has the same color of the background. I understand that it's for design reasons, but in order to don't have themes like those, I would like to remove those buttons.

I will remove also show_overlay, and show the underlying sloth background only if the overlay value is transparent and not opaque anymore (and hide it when the value of the overlay become opaque again).

stagfoo commented 7 years ago

oh sweet yer i think changing the show_overlay should just be a transparent makes the behavior more consistent. I think you are right about the button , the encourage people to make incomplete themes.

stagfoo commented 7 years ago

It would also simplify the builder code a lot which is nice

fandreuz commented 7 years ago

Ok, nice! Maybe I'm able to do it, let me know if you want to work on more difficult things and let this simple stuff to me ;D

stagfoo commented 7 years ago

yer sure, maybe just remove the button and I can clean up removing the functionality