fangchangma / sparse-to-dense.pytorch

ICRA 2018 "Sparse-to-Dense: Depth Prediction from Sparse Depth Samples and a Single Image" (PyTorch Implementation)
445 stars 101 forks source link

Question about input image resize #12

Closed ziqi-zhang closed 6 years ago

ziqi-zhang commented 6 years ago

Hi, I have a question about image resize in train_transform of nyu_dataloader. It is at line 60 of nyu_dataloader.py. I wonder how can resize operation speed up rotation?

ziqi-zhang commented 6 years ago

And I think for kitti dataset I don't need to resize to 240?

fangchangma commented 6 years ago

If I recall correctly, rotation is a more expensive operation than resizing and is size-dependent. It becomes a computational bottleneck when applied directly on the KITTI images.

Any image size > 224-by-224 should work.

ziqi-zhang commented 6 years ago

But in torch implementation there is no resize operation. You only crop bottom of the picture. I think your point is that if I resize the bottom of kitti picture to a square picture, rotation operation will be accelerated. Is that true?

fangchangma commented 6 years ago

The resizing operation doesn't change the image aspect ratio but accelerates the overall speed indeed. This resizing is by no means necessary, and feel free to remove it if it is a concern to you (make sure to change the second resizing accordingly).

whubaichuan commented 4 years ago

@ziqi-zhang @AbigailFernandes Hi, the download speed (13kb/s ) is too low when I use the command "wget http://datasets.lids.mit.edu/sparse-to-dense/data/nyudepthv2.tar.gz" even in VPN mode. How can I raise the download speed? Looking forward to your reply.