search

fangfufu / httpdirfs

A filesystem which allows you to mount HTTP directory listings or a single file, with a permanent cache. Now with Airsonic / Subsonic support!
Other
778 stars 59 forks source link

Fix a few bugs and code smells, but mostly convert to autotools #123

Closed jikamens closed 1 year ago

jikamens commented 1 year ago

The best way to review this PR is probably to review the commits one by one rather than reviewing them all at once, since each commit stands alone.

I have confirmed that the code in this PR builds and installs successfully on Debian Linux, FreeBSD, and macOS.

fangfufu commented 1 year ago

Thanks, I can see you put in a lot of efforts, and your code quality is really good. I have added you as a collaborator. You can now push into this project directly. :)

jikamens commented 1 year ago

@fangfufu I appreciate your confidence but I will still probably ask you to review any future changes that I want to commit, unless they are quite minor. Two pairs of eyes are better than one!

fangfufu commented 1 year ago

@jikamens , I don't give collaborator access out to everyone - the only other person I have given it to is my Debian package maintainer.

jikamens commented 6 months ago

Thanks for catching those errors! Sorry about that.