search

fangli / fluent-plugin-influxdb

A buffered output plugin for fluentd and InfluxDB
MIT License
111 stars 65 forks source link

Add space to end of tag value if it ends with a back slash #93

Closed metal-hed closed 5 years ago

metal-hed commented 5 years ago

Hoping to merge this change in to work around influxdb issue https://github.com/influxdata/influxdb/issues/5231

repeatedly commented 5 years ago

Do you report this problem on influxdb-ruby repository?

metal-hed commented 5 years ago

I did not, I can open an issue there if it is more appropriate

repeatedly commented 5 years ago

I did not, I can open an issue

It should because we can merge your patch but it is workaround. If influxdb has a problem, official client should handle it.

After you report the issue on influxdb-ruby repository, we will merge the patch.

metal-hed commented 5 years ago

@repeatedly Bug reported to influxdb-ruby https://github.com/influxdata/influxdb-ruby/issues/225

I also updated the log message to debug level

metal-hed commented 5 years ago

I came across this fix in influxdb-ruby https://github.com/influxdata/influxdb-ruby/issues/200 and was release with v0.4.2, I am curious if this will fix the issue.

Would updating the dependency cause other changes to be made?

repeatedly commented 5 years ago

Ah, I see. We fixed influx-ruby version to support older environment before.

If latest version fixes many bugs, we can update dependency to latest version and release new fluent-plugin-influxdb as v2.0.

dmke commented 5 years ago

Just a heads up, the next influxdb gem release (containing this fix) will officially drop support for MRI 2.2 (reason being Bundler not supporting it anymore and no easy way do convince Travis to play nice here...).

I'm not actually removing 2.2 support, it's just that I can't test it anymore.

metal-hed commented 5 years ago

@repeatedly sounds like we have a work around to use. I will close this PR as it's not really needed anymore.

Thanks for the help!

metal-hed commented 5 years ago

Ah, I see. We fixed influx-ruby version to support older environment before.

If latest version fixes many bugs, we can update dependency to latest version and release new fluent-plugin-influxdb as v2.0.

@repeatedly Are you able to do this in the near future? If not could you point me to some documentation to do this myself on a forked repo? Mainly just want to upgrade the influx-ruby version being used