Hinting over an element with no url or source is not an error

fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.

https://fanglingsu.github.io/vimb/

GNU General Public License v3.0

1.34k stars 100 forks source link

Hinting over an element with no url or source is not an error #620

Closed mawww closed 4 years ago

mawww commented 4 years ago

focusHint returning "OVER:A:" because the hint element did not have a src or href was treated as an error, and led to the hint keystroke also being passed down to the page.

fanglingsu commented 4 years ago

@mawww Thank you for the patch.