search

fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.34k stars 100 forks source link

Embedding dmenu on a tabbed vimb cover the whole window #658

Closed toniz4 closed 3 years ago

toniz4 commented 3 years ago 
vimb --bug-info
Version:         3.6.0-30-ga8d6130
WebKit compile:  2.30.3
WebKit run:      2.30.3
GTK compile:     3.24.22
GTK run:         3.24.22
libsoup compile: 2.70.0
libsoup run:     2.70.0
Extension dir:   /usr/lib/vimb

Steps to reproduce

open dmenu in vimb inside tabbed with echo test | dmenu -w "$VIMB_XID"

Expected behaviour

dmenu being displayed only at the top of the client. When vimb is not inside tabbed it works as expected 2021-01-19-025545_720x750_scrot

Actual behaviour

dmenu covers the whole screen when vimb is inside tabbed (I have tabbed configured to only show the tabs when alt is pressed, the same thing happened with vanilla tabbed and dmenu) 2021-01-19-025801_679x750_scrot

fanglingsu commented 3 years ago

@toniz4 I'll have a look at that. I've never tried to run demu within vimb - for which use case to you use that?

toniz4 commented 3 years ago

I have a bookmark manager that i used to use with surf and something like a session manager. I could open dmenu without -w and open it in normally, but embedding it looks nicer and more concise. I would try to find a solution, but i don't know where to look.

fanglingsu commented 3 years ago

@toniz4 I've added the new env var VIMB_WIN_ID which always holds the window id of the gtk window. The VIMB_XID is the xid of the gtk window or in case of embedding the xid of tabbed.

toniz4 commented 3 years ago

Thanks for the quick response! it worked perfectly.