Hinting doesn't work on Gitlab

fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.

https://fanglingsu.github.io/vimb/

GNU General Public License v3.0

1.34k stars 100 forks source link

Hinting doesn't work on Gitlab #659

Closed TheGreatMcPain closed 3 years ago

TheGreatMcPain commented 3 years ago

Steps to reproduce

Go to a gitlab repository page and try to use hinting.

Expected behaviour

Have hinting appear on most of not all links.

Actual behaviour

Some yellow highlighting, no numbers, and no highlighting on items in the repository browser.

vimb-gitlab-issue

Debug Info

Version:         3.6.0-30-ga8d6130
WebKit compile:  2.30.3
WebKit run:      2.30.4
GTK compile:     3.24.22
GTK run:         3.24.22
libsoup compile: 2.70.0
libsoup run:     2.70.0
Extension dir:   /usr/lib/vimb

fanglingsu commented 3 years ago

@TheGreatMcPain Thank you for reporting this issue. I could reproduce it.I saw en error in the developer toolbar "TypeError: undefined is not an object (evaluating 'rect.left')" pointing to https://github.com/fanglingsu/vimb/blob/6b07416d773e2b48c6904c3590222e01f0a66725/src/scripts/hints.js#L178