search

fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.34k stars 99 forks source link

Add setting for toggling javascript markup option #669

Closed Sadoon-AlBader closed 2 years ago

Sadoon-AlBader commented 3 years ago

Older systems like ppc32 struggle with WebKit's JavaScript engine, having this setting turned off enables those systems to access most websites with limited JavaScript functionality instead of simply crashing WebKit on any JS website.

Was tested on Gentoo and ArchPower, works great.

PS: Thank you for creating this browser, it's refreshing to use such a fast browser with a small and simple codebase that people can look into and contribute to!

fanglingsu commented 3 years ago

@Sadoon-AlBader Thank you for your investigation. Could you please document this new setting in the man page doc/vimb.1 too. And we currently support webkit versions down to 2.20.x and this setting is only available from 2.24 on, so you should check the webkit version during compilation like this https://github.com/fanglingsu/vimb/blob/0b0060d95885f280bc635ea24d73078880951b29/src/setting.c#L109-L112

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had activity within the last 60 days.

Sadoon-AlBader commented 2 years ago

Just fixed both issues, sorry for taking so long :) I'm just now starting to use vimb as my main browser. Hope these commits make everything complete.

fanglingsu commented 2 years ago

@Sadoon-AlBader Thank you!