fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.34k stars 99 forks source link

Youtube/odysee not showing video thumbnail..check out the picture attached... #682

Closed unixbhaskar closed 2 years ago

unixbhaskar commented 2 years ago

This is happening across OSes , namely , precisely, Gentoo,Slackware,Debian,Arch,Tumbleweed.

Also tried to change theme to light/dark ...alas! the story is same. Wondering! I am sure, I am missing very obvious.

bhaskar@debian_06:09:47_Mon Sep 20: :~>vimb --bug-info Version: 3.6.0 WebKit compile: 2.30.3 WebKit run: 2.32.3 GTK compile: 3.24.22 GTK run: 3.24.24 libsoup compile: 2.70.0 libsoup run: 2.72.0 Extension dir: /usr/local/lib/vimb

Steps to reproduce

Open youtube.com/odysee.com and seeing this

Expected behaviour

Should show the video thumbnail

Actual behaviour

In the attached pic 2021-09-20-060738_1366x768_scrot

unixbhaskar commented 2 years ago

This issue has striking similarity... Some images won't load #97

Again! recompiled it doesn't solve the issue. Where am I missing?

Pls shed some light.

Sadoon-AlBader commented 2 years ago

Can you share you config and your style.css if you're using one?

unixbhaskar commented 2 years ago

@Sadoon-AlBader Here is my ...

Style Sheet: https://github.com/unixbhaskar/dotfiles/blob/master/vimb_style_config

Config : https://github.com/unixbhaskar/dotfiles/blob/master/vimb_config

Check out.

Sadoon-AlBader commented 2 years ago

Ah, as expected. The problem is with your stylesheet. Try :set stylesheet=off

Or consider using an autocmd to disable the stylesheet and enable dark-mode on specific websites like this:

:autocmd LoadStarted https://odysee.com/* set stylesheet=off | set dark-mode=on

Some sites, like odysee, do not respect dark mode and you need to toggle it from the site menu on the gear icon.

unixbhaskar commented 2 years ago

Ah, as expected. The problem is with your stylesheet. Try :set stylesheet=off

@Sadoon-AlBader Thanks a bunch!

Sadoon-AlBader commented 2 years ago

@Sadoon-AlBader Thanks a bunch!

You are most welcome :)

fanglingsu commented 2 years ago

@unixbhaskar The reaso for the missing images is following in you style.css

*,div,pre,textarea,body,input,td,tr,p
{
    background-color: #002b36 !important;
}

This sets background color to all elements. And I assume that this background covers the images or so. I've used a litte more fine grained approach to change the backgorunds and the images for the videos are shown. This is my style, which is only used if dark mode is enabled https://github.com/fanglingsu/dotfiles/blob/master/.config/vimb/style.css

unixbhaskar commented 2 years ago

@unixbhaskar The reaso for the missing images is following in you style.css

*,div,pre,textarea,body,input,td,tr,p
{
    background-color: #002b36 !important;
}

This sets background color to all elements. And I assume that this background covers the images or so. I've used a litte more fine grained approach to change the backgorunds and the images for the videos are shown. This is my style, which is only used if dark mode is enabled https://github.com/fanglingsu/dotfiles/blob/master/.config/vimb/style.css

Thanks , man! looks bloody good.