fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.34k stars 99 forks source link

Add option for WebKit Intelligent Tracking Prevention #693

Closed illfygli closed 2 years ago

illfygli commented 2 years ago

Please let me know if I got the version checks right. I could only find examples of checking the runtime version in vimb, but the ITP functions were introduced in 2.30 and I guess compilation would fail if I don't check the compile-time version.

fanglingsu commented 2 years ago

@illfygli You should use WEBKIT_CHECK_VERSION(2, 30, 0) which evaluates to true is the version is at least 2.30.0 https://webkitgtk.org/reference/webkit2gtk/stable/webkit2gtk-4.0-WebKitVersion.html#WEBKIT-CHECK-VERSION:CAPS

illfygli commented 2 years ago

Thanks, updated.

fanglingsu commented 2 years ago

@illfygli Thank you!