search

fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.34k stars 99 forks source link

`editor-command` doesn't work everywhere, quotes seem to break it, and `;e` doesn't offer hints #713

Closed machinedgod closed 2 weeks ago

machinedgod commented 2 years ago

Steps to reproduce

  1. set editor-command according to doc in config file: (#set editor-command=termite -e "nvim %s") set editor-command=urxvt -e vis %s (note lack of quotes!)
  2. try executing it on archlinux forums using ;e and CTRL-T. Also attempt Amazon and DuckDuckGo

Expected behaviour

Urxvt window with vis instance opens up, with text from the hinted field. When closed, contents would be transferred over to the hinted field.

Actual behaviour

  1. If quotes are retained, as in example - there is a quick flash then nothing happens. I presume Urxvt opens then immediately closes as quotes seem to break the command somehow
  2. on all three sites, hints aren't shown, but first field is sent to the external editor. This is understandable for archlinux forums and duckduckgo (as there's only one field), but amazon's Order page has two (search and search orders)
  3. on archlinux forums contents aren't transferred back into the post field. On duckduckgo, sometimes the searchbar contents are transferred to editor as 'undefined', and not transferred back (works second time around though). On amazon everything works, except I can't hint the field I'd like. If I manually hint at the field using f first, then it works normally.

Vimb --bug-info

Version:         3.6.0-58-gabff254
WebKit compile:  2.34.5
WebKit run:      2.36.3
GTK compile:     3.24.31
GTK run:         3.24.34
libsoup compile: 2.74.2
libsoup run:     2.74.2
Extension dir:   /usr/lib/vimb

Not using wyebadblock, but using hblock. No idea if that matters, but worth pointing out.

machinedgod commented 2 weeks ago

This seems to be fixed - I can't reproduce the error, and both ;e hinting and Ctrl+T immediate command work flawlessly. Unfortunately, I can't recall if there's any parmeter that I changed in the meantime that might affect it either.