search

fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.34k stars 99 forks source link

`g:{mode}{hint` executes hints immediately, not as a batch #714

Open machinedgod opened 2 years ago

machinedgod commented 2 years ago

Steps to reproduce

  1. execute g;t or g;o

Expected behaviour

Hints can be toggled as selected/unselected by hinting and manually with Enter. There can be multiple green hints. Escape starts the batch with all selected hints, CTRL+G aborts.

Actual behaviour

Mode command is executed as soon as hint is hinted. In case of g;t this is merely inconvenient, as focus is shifted to a new window, or in case of tabbed switched to a new tab. The g;o command in its plain form is also not useful even in proposed batch mode, as only the last hint would be opened. Perhaps it could be useful in combination with Handlers and AutoCommands.

vimb --bug-info

Version:         3.6.0-58-gabff254
WebKit compile:  2.34.5
WebKit run:      2.36.3
GTK compile:     3.24.31
GTK run:         3.24.34
libsoup compile: 2.74.2
libsoup run:     2.74.2
Extension dir:   /usr/lib/vimb

P.S. Sorry for reports flood, I just happened to run into all these in a short period. I'd like to help if I can somehow. P.S.2. I am writing this off to the instability of webkit2gtk, but I am getting a whole lot more webkit crashes. I was forced to write these issues in Firefox, as github window kept crashing on every form submission.