search

fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.33k stars 99 forks source link

main: fix compilation with FEATURE_NO_XEMBED #725

Closed pks-t closed 1 year ago

pks-t commented 1 year ago

When FEATURE_NO_XEMBED is defined then we don't support using the Xembed interface, which will cause us to set the VIMB_XID envvar. With 55fb9cc (Add new env VIMB_WIN_ID to hold the gtk window id., 2021-01-25) a related feature was added that causes us to expose the Gtk window ID via the VIMB_WIN_ID environment variable. This feature also depends on X-specific information because it uses GDK_WINDOW_XID() to derive the window ID. This change thus broke Wayland-only environments.

Fix compilation by extending the ifdef to guard the logic that both sets the VIMB_XID and the VIMB_WIN_ID.

fanglingsu commented 1 year ago

@pks-t Thank you for this contribution.