fanglingsu / vimb

Vimb - the vim like browser is a webkit based web browser that behaves like the vimperator plugin for the firefox and usage paradigms from the great editor vim. The goal of vimb is to build a completely keyboard-driven, efficient and pleasurable browsing-experience.
https://fanglingsu.github.io/vimb/
GNU General Public License v3.0
1.36k stars 100 forks source link

Check return value of ext_proxy_eval_script_sync. #759

Closed falsifian closed 10 months ago

falsifian commented 11 months ago

One of the two added checks fixes #745.

Caveat: I don't understand what the function normal_focus_last_active is supposed to return (and more generally don't know much about this codebase). I hope RESULT_ERROR is appropriate in this case.

FYI, I can trigger the other added check by going to https://www.facebook.com/ (I'm logged in) and then pressing "i". "i" continues to trigger the error even after I navigate to another page after that. It looks like something breaks when I visit that site (and some others). A warning is printed when ext_proxy_eval_script_sync is called: : ** (vimb:43081): WARNING **: 16:11:29.669: Failed dbus method EvalJs: The connection is closed. Maybe I'll look into that separately.

fanglingsu commented 10 months ago

@falsifian Thank you!