fangohr / octopus-in-spack

Develop Octopus in spack (software packaging)
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Align with octopus package in spack 2022 09 21 #30

Closed fangohr closed 2 years ago

fangohr commented 2 years ago

As the spack folks have run black (https://github.com/spack/spack/commit/f52f6e99dbf1131886a80112b8c79dfc414afb7c) over their whole repository (a good idea in principle) two months ago, our version of octopus/package.py and theirs have diverged.

This pull request is meant to bring the changes back.

We have two commits:

From the diff of the second commit, we can see that again there are only re-formatting changes taking place with the exception of this one:

-from spack import *
+from spack.package import *

In any case, I think it will be essential to base our future merge requests to spack upstream on exactly the octopus/package.py file that is in upstream.

[1] https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/octopus/package.py

fangohr commented 2 years ago

Thanks to @iamashwin99 for offline review.