search

fangohr / octopus-in-spack

Develop Octopus in spack (software packaging)
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Remove redundant FFLAGS #68

Closed iamashwin99 closed 1 year ago

iamashwin99 commented 1 year ago

Henning has found in his experiments that the octopus configure script dosent use the FFLAGS at all which we are setting, we can hence remove it from here to reduce clutter. For eg the sample output from octopus dosent include a section on FFLAGS:

Version                : 12.1
Commit                 :
Build time             : Mon Feb 27 21:57:54 CET 2023
Configuration options  : maxdim3 openmp mpi sse2 avx libxc5 libxc_fxc
Optional libraries     : cgal metis netcdf parmetis pfft nlopt
Architecture           : x86_64
C compiler             : /opt_mpsd/linux-debian11/dev-23a/sandybridge/spack/opt/spack/linux-debian11-sandybridge/gcc-11.3.0/openmpi-4.1.4-4lehnqllo3r6t45ix2wrdcew6lfwsdgw/bin/mpicc (/opt_mpsd/linux-debian11/dev-23a/sandybridge/spack/lib/spack/env/gcc/gcc)
C compiler flags       : -g -O2
C++ compiler           : /opt_mpsd/linux-debian11/dev-23a/sandybridge/spack/lib/spack/env/gcc/g++
C++ compiler flags     : -g -O2
Fortran compiler       : /opt_mpsd/linux-debian11/dev-23a/sandybridge/spack/opt/spack/linux-debian11-sandybridge/gcc-11.3.0/openmpi-4.1.4-4lehnqllo3r6t45ix2wrdcew6lfwsdgw/bin/mpif90 (/opt_mpsd/linux-debian11/dev-23a/sandybridge/spack/lib/spack/env/gcc/gfor
Fortran compiler flags : -O2 -ffree-line-length-none -fallow-argument-mismatch -fallow-invalid-boz -fopenmp

This MR fixes #65

fangohr commented 1 year ago

Closed on purpose? If removing FFflags is the right thing to do, then we should do it?

iamashwin99 commented 1 year ago

This MR has been included in https://github.com/fangohr/octopus-in-spack/pull/70