fangohr / octopus-in-spack

Develop Octopus in spack (software packaging)
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Simplify and shorten syntax for compiler flag generation #95

Closed lang-m closed 9 months ago

lang-m commented 1 year ago

This proposed change only works if the order of -fallow-argument-mismatch -fallow-invalid-boz and -g does not matter, which I do not know.

It came up during a review of mpsd-computational-science/spack#15

fangohr commented 1 year ago

Should be re-run after branch fix-issue-96 (#96) is merged to check for failure. Or rebase on that branch here.

lang-m commented 9 months ago

@fangohr Could you please approve this. (And maybe change my permissions afterwards.)

fangohr commented 9 months ago

Need to review package.py anyway with upcoming changes, closing this.